Skip to content

Add native types where possible #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add native types where possible #118

merged 1 commit into from
Jul 25, 2023

Conversation

derrabus
Copy link
Member

This PR improves the typing throughout the codebase:

  • Native types are added where possible without a BC break
  • PHPDoc@return annotations have been added to prevent deprecations triggered by ErrorHandler
  • More PHPDoc has been added where a native type cannot be set as long as we support PHP 7.2.
  • PHPUnit data providers have been declared static.

@derrabus
Copy link
Member Author

fabbot error is unrelated

@derrabus derrabus requested a review from nicolas-grekas July 25, 2023 08:38
@derrabus derrabus merged commit 18c9e82 into symfony:main Jul 25, 2023
@derrabus derrabus deleted the improvement/types branch July 25, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @nicolas-grekas